V26.2.0-IOFreeze: new Absorptance Inside Face fields - #5648
V26.2.0-IOFreeze: new Absorptance Inside Face fields#5648joseph-robertson wants to merge 8 commits into
Conversation
🧪 Test Results DashboardSummary
❌ Significant Test Failures📊 Test Run Information
|
There was a problem hiding this comment.
🟡 Changes recommended
The blank Material:NoMass reverse-translation test uses incorrect field indices, invalidating its fallback assertions.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds inside-face absorptance support for standard and massless opaque materials, including blank-value inheritance and EnergyPlus translation.
Changes:
- Extends the model schema and APIs with three inside-face absorptance fields.
- Adds forward and reverse translation support.
- Adds model and translator tests.
File summaries
| File | Description |
|---|---|
resources/model/OpenStudio.idd |
Defines the optional fields. |
src/model/StandardOpaqueMaterial.hpp |
Exposes the standard-material API. |
src/model/StandardOpaqueMaterial_Impl.hpp |
Declares implementation methods. |
src/model/StandardOpaqueMaterial.cpp |
Implements fallback and mutation behavior. |
src/model/MasslessOpaqueMaterial.hpp |
Exposes the massless-material API. |
src/model/MasslessOpaqueMaterial_Impl.hpp |
Declares implementation methods. |
src/model/MasslessOpaqueMaterial.cpp |
Implements fallback and mutation behavior. |
src/model/test/StandardOpaqueMaterial_GTest.cpp |
Tests standard-material behavior. |
src/model/test/MasslessOpaqueMaterial_GTest.cpp |
Tests massless-material behavior. |
src/energyplus/ForwardTranslator/ForwardTranslateStandardOpaqueMaterial.cpp |
Writes explicit standard-material values. |
src/energyplus/ForwardTranslator/ForwardTranslateMasslessOpaqueMaterial.cpp |
Writes explicit massless-material values. |
src/energyplus/ReverseTranslator/ReverseTranslateMaterial.cpp |
Imports standard-material values. |
src/energyplus/ReverseTranslator/ReverseTranslateMaterialNoMass.cpp |
Imports massless-material values. |
src/energyplus/Test/ForwardTranslator_GTest.cpp |
Tests omission and emission behavior. |
src/energyplus/Test/ReverseTranslator_GTest.cpp |
Tests imports and blank-field fallback. |
Review details
- Files reviewed: 15/15 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
NatLabRockies/EnergyPlus#11750 adds new output variables:
But I'm not sure whether these should be added to any |
Pull request overview
Pull Request Author
src/model/test)src/energyplus/Test)src/osversion/VersionTranslator.cpp)Labels:
IDDChangeAPIChangePull Request - Ready for CIso that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.